Differential D12306

Conpherence - only validate new participants when validating TYPE_PARTICIPANT transactions
ClosedPublic
Actions

Authored by btrahan on Apr 6 2015, 6:39 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7693: Allow users to leave threads with members who are invalid or have been destroyed

Commits

Restricted Diffusion Commit
rPa55fb95bd5ae: Conpherence - only validate **new** participants when validating…

Summary

Fixes T7693.

Test Plan

made a conpherence with my main test account and a throwaway test account. deleted the test account. removed myself from the thread. added myself back to the thread.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29548.Apr 6 2015, 6:39 PM

btrahan added a task: T7693: Allow users to leave threads with members who are invalid or have been destroyed.

btrahan retitled this revision from to Conpherence - only validate **new** participants when validating TYPE_PARTICIPANT transactions.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 6 2015, 6:39 PM

Screen_Shot_2015-04-06_at_11.36.33_AM.png (1×2 px, 518 KB)

(removed my self, then manually navigated via URI bar to the thread)

Screen_Shot_2015-04-06_at_11.36.50_AM.png (1×2 px, 519 KB)

Screen_Shot_2015-04-06_at_11.37.39_AM.png (1×2 px, 475 KB)

Screen_Shot_2015-04-06_at_11.37.43_AM.png (1×2 px, 560 KB)

epriestley accepted this revision.Apr 6 2015, 6:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2015, 6:45 PM

Closed by commit rPa55fb95bd5ae: Conpherence - only validate **new** participants when validating… (authored by btrahan, committed by btrahan). · Explain WhyApr 6 2015, 6:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

editor/

ConpherenceEditor.php

6 lines

Diff 29549

View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Conpherence - only validate **new** participants when validating TYPE_PARTICIPANT transactionsClosedPublicActions