Page MenuHomePhabricator

Don't show comment draft state to non-object-owners

Authored by epriestley on Apr 2 2015, 2:15 PM.
Referenced Files
Unknown Object (File)
Tue, Mar 28, 7:43 AM
Unknown Object (File)
Mon, Mar 27, 11:04 PM
Unknown Object (File)
Wed, Mar 22, 12:50 AM
Unknown Object (File)
Feb 4 2023, 1:52 AM
Unknown Object (File)
Jan 22 2023, 12:33 PM
Unknown Object (File)
Jan 12 2023, 6:15 AM
Unknown Object (File)
Dec 12 2022, 11:42 AM
Unknown Object (File)
Nov 30 2022, 3:30 AM



Fixes T7720. We currently leak the "draft" state of checkboxes; never treat checkboxes as drafts if you can't mark them.

Test Plan

Checked a box, reloaded page in other browser. Previously, the draft state partially propagated. Now, it no longer does.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't show comment draft state to non-object-owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Apr 2 2015, 2:16 PM
This revision was automatically updated to reflect the committed changes.