Page MenuHomePhabricator

Don't show comment draft state to non-object-owners
ClosedPublic

Authored by epriestley on Apr 2 2015, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 28, 2:44 PM
Unknown Object (File)
Fri, Jun 27, 5:24 AM
Unknown Object (File)
Jun 1 2025, 6:09 PM
Unknown Object (File)
May 30 2025, 7:19 PM
Unknown Object (File)
May 28 2025, 2:21 PM
Unknown Object (File)
May 27 2025, 6:10 AM
Unknown Object (File)
Apr 28 2025, 5:14 AM
Unknown Object (File)
Apr 23 2025, 11:50 PM
Subscribers

Details

Summary

Fixes T7720. We currently leak the "draft" state of checkboxes; never treat checkboxes as drafts if you can't mark them.

Test Plan

Checked a box, reloaded page in other browser. Previously, the draft state partially propagated. Now, it no longer does.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't show comment draft state to non-object-owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Apr 2 2015, 2:16 PM
This revision was automatically updated to reflect the committed changes.