Page MenuHomePhabricator
Differential D12249

Expose all application mail receivers
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 6:33 PM.
Tags
None
Referenced Files
F15423336: D12249.id29423.diff
Sat, Mar 22, 2:55 PM
F15419747: D12249.id.diff
Fri, Mar 21, 8:35 AM
F15419584: D12249.id29416.diff
Fri, Mar 21, 7:10 AM
F15416709: D12249.diff
Thu, Mar 20, 1:04 PM
F15395518: D12249.diff
Sun, Mar 16, 7:37 AM
F15390378: D12249.id.diff
Sat, Mar 15, 6:10 AM
F15390270: D12249.id29423.diff
Sat, Mar 15, 6:04 AM
F15389539: D12249.id.diff
Sat, Mar 15, 5:23 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7199: Expand the power of "!action" commands in email
Commits
Restricted Diffusion Commit
rPeb81fd15628f: Expose all application mail receivers
Summary

Fixes T7199. This still isn't a shining example of perfect code, but the raw amount of copy/paste is much lower than it used to be.

  • Reduce code duplication between existing receivers.
  • Expose receiving objects in help menus where appropriate.
  • Connect some "TODO" receivers.
Test Plan
  • Sent mail to every supported object type.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29416.Apr 1 2015, 6:33 PM
epriestley retitled this revision from to Expose all application mail receivers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7199: Expand the power of "!action" commands in email.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 6:33 PM
btrahan accepted this revision.Apr 1 2015, 6:41 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 6:41 PM
Closed by commit rPeb81fd15628f: Expose all application mail receivers (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 6:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
7 lines
applications/
audit/
editor/
6 lines
mail/
13 lines
conpherence/
application/
10 lines
mail/
14 lines
storage/
26 lines
differential/
mail/
13 lines
diffusion/
application/
13 lines
files/
application/
13 lines
mail/
14 lines
legalpad/
application/
13 lines
mail/
LegalpadMailReceiver.php
LegalpadMockMailReceiver.php
16 lines
macro/
application/
13 lines
mail/
9 lines
maniphest/
mail/
14 lines
metamta/
receiver/
20 lines
paste/
application/
13 lines
mail/
14 lines
pholio/
application/
13 lines
mail/
8 lines
ponder/
application/
13 lines
mail/
9 lines
releeph/
application/
7 lines
mail/
9 lines

Diff 29423

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/audit/mail/PhabricatorAuditMailReceiver.php

Loading...
View Options

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

Loading...
View Options

src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceThread.php

Loading...
View Options

src/applications/differential/mail/DifferentialMail.php

Loading...
View Options

src/applications/differential/mail/DifferentialRevisionMailReceiver.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/mail/FileMailReceiver.php

Loading...
View Options

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

Loading...
View Options

src/applications/legalpad/mail/LegalpadMailReceiver.php

Loading...
View Options

src/applications/legalpad/mail/LegalpadMockMailReceiver.php

Loading...
View Options

src/applications/macro/application/PhabricatorMacroApplication.php

Loading...
View Options

src/applications/macro/mail/PhabricatorMacroMailReceiver.php

Loading...
View Options

src/applications/maniphest/mail/ManiphestTaskMailReceiver.php

Loading...
View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Loading...
View Options

src/applications/paste/application/PhabricatorPasteApplication.php

Loading...
View Options

src/applications/paste/mail/PasteMailReceiver.php

Loading...
View Options

src/applications/pholio/application/PhabricatorPholioApplication.php

Loading...
View Options

src/applications/pholio/mail/PholioMockMailReceiver.php

Loading...
View Options

src/applications/ponder/application/PhabricatorPonderApplication.php

Loading...
View Options

src/applications/ponder/mail/PonderQuestionMailReceiver.php

Loading...
View Options

src/applications/releeph/application/PhabricatorReleephApplication.php

Loading...
View Options

src/applications/releeph/mail/ReleephRequestMailReceiver.php

Loading...
Phabricator · Built by Phacility