Page MenuHomePhabricator

Remove reply handler instructions from email
ClosedPublic

Authored by epriestley on Mar 31 2015, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:29 PM
Unknown Object (File)
Wed, Apr 24, 10:30 PM
Unknown Object (File)
Tue, Apr 9, 7:18 AM
Unknown Object (File)
Sat, Apr 6, 6:03 PM
Unknown Object (File)
Apr 2 2024, 6:42 PM
Unknown Object (File)
Apr 1 2024, 4:45 PM
Unknown Object (File)
Mar 10 2024, 6:12 AM
Unknown Object (File)
Feb 14 2024, 8:45 AM
Subscribers

Details

Summary

Ref T7199. Although this is useful for discovery, it's un-useful enough that we already have an option to disable it, and most applications do not provide any meaningful instructions.

Throwing it away makes it easier to move forward and lets us get rid of a config option.

This is becoming a more advanced/power-user feature anyway, and the new syntax will be significantly more complex and hard to explain with a one-liner. I'm currently thinking that I'll maybe make the "help" menu a dropdown and give it some options like:

+---+
| O |
+---+---------------------+
| Maniphest Documentation |
| Maniphest Email Actions |
+-------------------------+

Then you click the "Email Actions" thing and get a runtime-derived list of available options. Not sure if I'll actually build that, but I think we can fairly throw the in-mail instructions away even if we don't go in that specific direction.

Test Plan

Grepped for replyHandlerInstructions, got no hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove reply handler instructions from email.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Good stuff. I like the idea of help as a menu dropdown a great deal. This is some complex stuff and I think surfacing the docs is a big win.

This revision is now accepted and ready to land.Mar 31 2015, 10:43 PM
This revision was automatically updated to reflect the committed changes.