Make column show/hide behaviors a little simpler
ClosedPublic
Actions

Authored by epriestley on Mar 28 2015, 10:44 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width

Commits

Restricted Diffusion Commit
rP69020af0c7f6: Make column show/hide behaviors a little simpler

Summary

Ref T7062. The previous fix caused an extra, unnecessary thread load on mobile. Make this code a bit simpler and fix the unnecessary load.

Test Plan

No more load on mobile.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29311.Mar 28 2015, 10:44 PM

epriestley retitled this revision from to Make column show/hide behaviors a little simpler.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 28 2015, 10:44 PM

chad accepted this revision.Mar 29 2015, 4:20 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 29 2015, 4:20 AM

Closed by commit rP69020af0c7f6: Make column show/hide behaviors a little simpler (authored by epriestley, committed by epriestley). · Explain WhyMar 29 2015, 2:27 PM

This revision was automatically updated to reflect the committed changes.

btrahan awarded a token.Mar 29 2015, 4:43 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

28 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

71 lines

Diff 29317

View Options

resources/celerity/map.php