Fix a race condition with the chat column
ClosedPublic
Actions

Authored by epriestley on Mar 28 2015, 10:20 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width

Commits

Restricted Diffusion Commit
rPa48b486344f6: Fix a race condition with the chat column

Summary

Ref T7062. When we load a thread, we always show the column, even if it has been closed between the time we sent the request and when we're processing the response.

Normally this isn't a big deal, but it can specifically show up on mobile.

(This load also shouldn't be happening at all, but I'll fix that separately.)

Test Plan

Mobile no longer shows the column after it loads.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29310.Mar 28 2015, 10:20 PM

epriestley retitled this revision from to Fix a race condition with the chat column.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7062: JX.Device should calculate display width based on frame width (i.e., subtract chat column) not total browser width.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 28 2015, 10:20 PM

chad accepted this revision.Mar 28 2015, 10:21 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 28 2015, 10:21 PM

Closed by commit rPa48b486344f6: Fix a race condition with the chat column (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2015, 10:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

24 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

6 lines

Diff 29313

View Options

resources/celerity/map.php