Page MenuHomePhabricator

Improve column device behaviors
ClosedPublic

Authored by epriestley on Mar 28 2015, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 10:49 AM
Unknown Object (File)
Thu, Nov 28, 4:45 AM
Unknown Object (File)
Thu, Nov 28, 3:40 AM
Unknown Object (File)
Thu, Nov 21, 5:37 PM
Unknown Object (File)
Wed, Nov 20, 9:26 AM
Unknown Object (File)
Nov 16 2024, 3:36 AM
Unknown Object (File)
Nov 12 2024, 8:58 AM
Unknown Object (File)
Nov 11 2024, 7:38 PM
Subscribers

Details

Summary

Fixes T7062. When the column is open, we only want to consider the screen width which is avilable for content when computing responsive breakpoints.

Specificially, if you have a 1000px wide browser window (normally "desktop") but the column is open (300px) so you only have 700px free for content (normally "tablet"), we should drop to the tablet breakpoint. This lets you have a narrow column of "tablet" content next to the chat column, instead of a really squished column of "desktop" contnet.

This also means the chat column can't directly use JX.Device to hide itself.

Test Plan

Resized screen with column open, saw content go from Desktop + Column -> Tablet + Column -> Tablet -> Mobile.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve column device behaviors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2015, 1:53 PM
This revision was automatically updated to reflect the committed changes.