Page MenuHomePhabricator

Add some spacing around jx-tooltips
ClosedPublic

Authored by chad on Mar 27 2015, 4:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 10:52 AM
Unknown Object (File)
Thu, Apr 11, 7:59 AM
Unknown Object (File)
Thu, Apr 11, 7:35 AM
Unknown Object (File)
Thu, Apr 11, 3:08 AM
Unknown Object (File)
Mar 23 2024, 5:10 AM
Unknown Object (File)
Feb 15 2024, 5:03 AM
Unknown Object (File)
Feb 15 2024, 5:03 AM
Unknown Object (File)
Feb 15 2024, 4:51 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP90ccd37a8c47: Add some spacing around jx-tooltips
Summary

Using tooltips with icons is problematic because we currently draw the arrow after the tooltip location, meaning it goes 5px into the container. This gives a 5px padding around the outer container to better account for this.

Test Plan

tested tooltips in remarkup bar, project icon nav, and in durable column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add some spacing around jx-tooltips.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 27 2015, 5:37 PM
This revision was automatically updated to reflect the committed changes.