Page MenuHomePhabricator
Differential D12160

Mostly provide CSS for "done" states
ClosedPublic
Actions

Authored by epriestley on Mar 25 2015, 5:51 PM.
Tags
None
Referenced Files
F18110433: D12160.id29230.diff
Mon, Aug 11, 7:36 PM
F18103037: D12160.id.diff
Sun, Aug 10, 1:13 AM
F18102290: D12160.id29229.diff
Sat, Aug 9, 7:45 PM
F18098717: D12160.diff
Fri, Aug 8, 10:45 PM
F17751570: D12160.diff
Jul 22 2025, 5:45 AM
F17750471: D12160.id.diff
Jul 22 2025, 3:39 AM
F17749569: D12160.id29229.diff
Jul 22 2025, 1:50 AM
Unknown Object (File)
Jun 8 2025, 4:11 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T7660: Clicking "Done" should set a CSS class on the inline-comment-box
Commits
Restricted Diffusion Commit
rP1fd163d0976c: Mostly provide CSS for "done" states
Summary

Ref T7660. I'm not toggling "inline-state-is-draft" correctly in JS yet since it's a little tricky (you can reload to see it) but the main state should work.

Test Plan
  • Clicked "done", saw comment opacity fade with placeholder style.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29229.Mar 25 2015, 5:51 PM
epriestley retitled this revision from to Mostly provide CSS for "done" states.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7660: Clicking "Done" should set a CSS class on the inline-comment-box.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 25 2015, 5:51 PM
chad accepted this revision.Mar 25 2015, 5:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2015, 5:53 PM
Closed by commit rP1fd163d0976c: Mostly provide CSS for "done" states (authored by epriestley, committed by epriestley). · Explain WhyMar 25 2015, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
src/
infrastructure/
diff/
view/
19 lines
webroot/
rsrc/
css/
application/
differential/
8 lines
js/
application/
differential/
9 lines

Diff 29230

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

Loading...
Phabricator · Built by Phacility