Differential D12118

Move property transaction construction to Almanac
ClosedPublic
Actions

Authored by epriestley on Mar 20 2015, 9:46 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7627: Get test coverage on instance setup

Commits

Restricted Diffusion Commit
rPc7178b7e7b39: Move property transaction construction to Almanac

Summary

Ref T7627. This centralizes this transaction construction code so the unit tests and Instances can both use it.

Test Plan

See D12116.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29141.Mar 20 2015, 9:46 PM

epriestley retitled this revision from to Move property transaction construction to Almanac.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7627: Get test coverage on instance setup .

Herald added a subscriber: epriestley. · View Herald TranscriptMar 20 2015, 9:46 PM

btrahan accepted this revision.Mar 23 2015, 3:51 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 23 2015, 3:51 PM

Closed by commit rPc7178b7e7b39: Move property transaction construction to Almanac (authored by epriestley, committed by epriestley). · Explain WhyMar 23 2015, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

storage/

AlmanacProperty.php

34 lines

Diff 29173

View Options

src/applications/almanac/storage/AlmanacProperty.php

Move property transaction construction to AlmanacClosedPublicActions