Ref T7582. Also adds the basic logic for "rooms" implementation. Also makes sure we use the initializeNewThread method as appropriate.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7582: Implement policies in Conpherence to support rooms
- Commits
- Restricted Diffusion Commit
rP85de4419a5f1: Conpherence - add storage for view / edit / join policy
made a new conpherence and it worked!
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/conpherence/storage/ConpherenceThread.php | ||
|---|---|---|
| 35 | This might need to be 1 explicitly in SQL strict mode. | |
| 237–239 | Oh, I think there might be a special case here: we should probably still give you view permission automatically if you're a member of a room, even if it technically violates the view policy. That is, return false for edit/join, but drop down to the participant check for view. A use case is "make the view policy 'no one', then invite people you like". This is also consistent with Projects, which have a similar rule (you can always view projects you're a member of). | |