Page MenuHomePhabricator
Differential D12102

Conpherence - add isRoom column to thread table
ClosedPublic
Actions

Authored by btrahan on Mar 17 2015, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 12:42 AM
Unknown Object (File)
Tue, Apr 30, 4:55 PM
Unknown Object (File)
Tue, Apr 30, 4:55 PM
Unknown Object (File)
Tue, Apr 30, 4:54 PM
Unknown Object (File)
Mon, Apr 29, 2:23 PM
Unknown Object (File)
Mon, Apr 15, 9:41 AM
Unknown Object (File)
Sun, Apr 7, 10:49 AM
Unknown Object (File)
Apr 3 2024, 5:20 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7583: Add a "room" flag to Conpherence
Commits
Restricted Diffusion Commit
rP9bda03dbceed: Conpherence - add isRoom column to thread table
Summary

Fixes T7583. We also add key_room, which uses isRoom and dateModified since a very common view of rooms is going to be ordered by last updated.

Test Plan

made the conpherence view controller query specify withIsRoom(true) and withIsRoom(false). The former made the controller correctly 404 while the latter had no change in functionality.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29112.Mar 17 2015, 10:35 PM
btrahan added a task: T7583: Add a "room" flag to Conpherence.
btrahan retitled this revision from to Conpherence - add isRoom column to thread table.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 17 2015, 10:35 PM
epriestley accepted this revision.Mar 17 2015, 10:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2015, 10:36 PM
Closed by commit rP9bda03dbceed: Conpherence - add isRoom column to thread table (authored by btrahan, committed by btrahan). · Explain WhyMar 17 2015, 10:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines
src/
applications/
conpherence/
query/
17 lines
storage/
4 lines

Diff 29113

View Options

resources/sql/autopatches/20150317.conpherence.isroom.1.sql

Loading...
View Options

resources/sql/autopatches/20150317.conpherence.isroom.2.sql

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceThread.php

Loading...
Phabricator · Built by Phacility