Differential D12099
Conpherence - update the "unread" count in notifications panel aggressively Authored by btrahan on Mar 17 2015, 8:34 PM. Tags None Referenced Files
Subscribers
Details
Fixes T7561. Basically everytime we load some transactions in the thread manager, kick off an async thread to update the notification panel. Should I consolidate this little bit of code into something like this._handleTransactionResponse(r)... ? I just want to keep the JS clear for other engineers and I wasn't sure if that was hiding a bit too much detail. user a opened durable column. user b sent user a a few messages. reloaded user a page and noted the "N" count became N-1 as the message loaded. Switched messages and saw N-2, N-3, etc as I loaded up the messages.
Diff Detail
Event TimelineComment Actions It might also make sense to piggyback this stuff on the response at some point (so when you query for messages, you also get the menu state back) but this diff is pretty simple/clean/reasonable until we have a stronger motivation for that. |