Differential D12091
Conpherence - fix 0 messages in header race condition Authored by btrahan on Mar 16 2015, 9:18 PM. Tags None Referenced Files
Subscribers
Details
Fixes T7545. Turns out we had the right logic to handle this basically, and just needed to variablize the CSS class that gets added / removed as appropos. Note the new behavior is to keep the icon highlighted just with no number. This emulates how it would work if e.g. there was no unread message in the first place and you just clicked the message icon to invoke the message menu. had a durable conpherence open for user A with user B. used a separate browser to send message as user B. reloaded as user A - saw new message in conpherence durable column and the "1" unread icon. I then clicked the "1" and saw it disappear as expected
Diff Detail
Event TimelineComment Actions
This seems incongruous, or maybe I'm reading it wrong -- I'd expect it to be un-highlighted if there's no number, but I think that's how it works if there are no unread messages? Possible I just don't know how the product works. Specifically, I'd expect this to look like there are no unread messages -- effectively, for receiving the chat to "count" as reading the message. Comment Actions If you click on either the notification or conpherence alert UI with nothing "unread", they both highlight and invoke a menu below them. The UI resembles this base state now (as opposed to having an erroneous "0"). It is still highlighted though. |