Differential D12086

Improve Conpherence column textarea JS behaviors
ClosedPublic
Actions

Authored by epriestley on Mar 14 2015, 6:50 PM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPe5580d038dd1: Improve Conpherence column textarea JS behaviors

Summary

Don't show a loading state on the whole column while sending chat. We could show some kind of minor loading state, but standard JX.Busy stuff will kick in after a couple seconds anyway.
Blank the textarea immediately on submit so you can start typing more text.
Don't disable the form while submiting; disabling it prevents you from typing more text.
Hide the placeholder while the textarea is focused. If we don't do this, the placeholder reappearing after submitting text feels weird to me.

Test Plan

Sent a lot of text.
Real fast.
Focused and unfocused the area.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29070.Mar 14 2015, 6:50 PM

epriestley retitled this revision from to Improve Conpherence column textarea JS behaviors.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 14 2015, 6:50 PM

place hodor

chad accepted this revision.Mar 14 2015, 6:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2015, 6:57 PM

General behavioral thing here is that typing a bunch of text real fast and mashing return a lot should send all the text you typed, not some of the text you typed.

Closed by commit rPe5580d038dd1: Improve Conpherence column textarea JS behaviors (authored by epriestley, committed by epriestley). · Explain WhyMar 14 2015, 7:00 PM

This revision was automatically updated to reflect the committed changes.