Conpherence - support device in durable column
ClosedPublic
Actions

Authored by btrahan on Mar 12 2015, 7:10 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rPeed10e47c9b5: Conpherence - support device in durable column

Summary

Ref T7014. This makes it so

you can't invoke the column from a device
if you are in desktop size and resize to tablet or phone, the column closes.
if you resize desktop -> device -> desktop, the column closes at device size and reopens at desktop size
if you load, then resize device -> desktop the column opens if the user has that preference
there is a brief flicker when you load on 'device' with the column open preference. it lasts as long as the js stack takes to calculate the device css rule.

Test Plan

see summary but i did stuff to do all that

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29009.Mar 12 2015, 7:10 PM

btrahan retitled this revision from to Conpherence - support device in durable column.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 12 2015, 7:10 PM

epriestley accepted this revision.Mar 12 2015, 7:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2015, 7:11 PM

see summary but i did stuff to do all that

hehe

There's some junk in PhabricatorStandardPageView->getBodyClasses() that tries to guess UAs to avoid content flashes, which we could use at some point.

The CSS rules have us covered then if the right UAs are beamed up. :D

In the "size the desktop small to simulate" case there's there's the flash during the race between the JX.Device code adding the right body class (wins I'd say) vs the durable column hide call on line 300.

Closed by commit rPeed10e47c9b5: Conpherence - support device in durable column (authored by btrahan, committed by btrahan). · Explain WhyMar 12 2015, 7:23 PM

This revision was automatically updated to reflect the committed changes.