Differential D12047

Conpherence - fix "pop in" effect
ClosedPublic
Actions

Authored by btrahan on Mar 11 2015, 11:14 PM.

Tags

None

Referenced Files

	F15498499: D12047.id28998.diff
	Sun, Apr 13, 1:04 PM

	F15494574: D12047.id28998.diff
	Sun, Apr 13, 12:45 AM

	F15494573: D12047.id.diff
	Sun, Apr 13, 12:45 AM

	F15491126: D12047.diff
	Fri, Apr 11, 11:46 PM

	F15462601: D12047.id28998.diff
	Tue, Apr 1, 4:19 PM

	F15434003: D12047.id28997.diff
	Tue, Mar 25, 1:30 AM

	F15428885: D12047.id28997.diff
	Sun, Mar 23, 11:01 PM

	F15420634: D12047.id28997.diff
	Fri, Mar 21, 3:39 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rP7d7deaf69802: Conpherence - fix "pop in" effect

Summary

Ref T7014. This got broken in today's action. For whatever reason the only way I can get the CSS to show up correctly is to move the require statement to where it was before rP5ef99dba2afc9f9ed3ca77707366a78be15f4871. Otherwise, this feature massages the UI a bit to make sure the "loading" stuff is set correctly in this state.

Test Plan

toggled conpherence open and it looked good. reloaded and it looked good.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28997.Mar 11 2015, 11:14 PM

btrahan retitled this revision from to Conpherence - fix "pop in" effect.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 11 2015, 11:14 PM

epriestley accepted this revision.Mar 11 2015, 11:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2015, 11:19 PM

Closed by commit rP7d7deaf69802: Conpherence - fix "pop in" effect (authored by btrahan, committed by btrahan). · Explain WhyMar 11 2015, 11:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

22 lines

src/

applications/

conpherence/

view/

ConpherenceDurableColumnView.php

19 lines

view/

page/

PhabricatorStandardPageView.php

4 lines

Diff 28998

resources/celerity/map.php

Loading...

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...

src/view/page/PhabricatorStandardPageView.php

Loading...