I think there's issues calculating he height (and width) of the containing element if the interior elements like images don't have a height set?

This can be a problem when e.g. trying to autoscroll the conpherence message window... If interior elements don't have specific heights / widths then we can't scroll enough until we figure out what the real height is....

Hope that makes sense / maybe this is obviated by other changes. We definitely had to do work to add image dimensions to files (and render them consistently) for this (and other) reasons though.

Hrm...

So what are the options here? This works correctly, rendering wise, but not scrolling wise. Sounds like any "correct" solution would be JS based.

Also, looks like meme's don't post height/width, so that'd need fixing anyways.

what if we

• set width and height to known values (may be huge) inline
• set max-width and max-height to fancy, correct CSS values

...then I think any javascript should calculate "too much" space over too little. For now, functionally that's okay since we are always scrolling to the bottom as far as I know. I think the CSS part will work correctly but I don't know for sure.

This seems to work in practice. The height and width are moved to img attributes instead of CSS styles. Not sure how to solve this in the macro sense, but that's not a regression at least.

This seems to work for macros on scrollbars, but fullsized remarkup images and memes need to add height/width support.

Haha, given that last image macro, I'll defer to @epriestley... :D

(Old files may not have dimensions, but the getWidth/Height calls will return null and phutil_tag() should decline to render the attribute when the value is null, so this should work fine for them.)

oh you