Page MenuHomePhabricator
Differential D12037

Conpherence - add icon-based room switcher to durable column view
ClosedPublic
Actions

Authored by btrahan on Mar 10 2015, 10:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Mon, Apr 29, 2:18 PM
Unknown Object (File)
Thu, Apr 25, 1:01 AM
Unknown Object (File)
Fri, Apr 19, 4:41 AM
Unknown Object (File)
Fri, Apr 12, 3:19 PM
Unknown Object (File)
Thu, Apr 11, 8:45 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T7380: Build icon-based room switcher for persistent chat pane
Commits
Restricted Diffusion Commit
rP4674a5eab93b: Conpherence - add icon-based room switcher to durable column view
Summary

Ref T7380. This does the most basic thing ever and sticks up to 6 icons in there.

Test Plan

clicked the icons and noted new conpherences loaded in nicely

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28973.Mar 10 2015, 10:28 PM
btrahan added a task: T7380: Build icon-based room switcher for persistent chat pane.
btrahan retitled this revision from to Conpherence - add icon-based room switcher to durable column view.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added a reviewer: chad. · View Herald TranscriptMar 10 2015, 10:28 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Mar 10 2015, 10:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2015, 10:29 PM
chad edited edge metadata.Mar 10 2015, 10:30 PM

plustwo

Closed by commit rP4674a5eab93b: Conpherence - add icon-based room switcher to durable column view (authored by btrahan, committed by btrahan). · Explain WhyMar 10 2015, 10:30 PM
This revision was automatically updated to reflect the committed changes.
chad added inline comments.Mar 10 2015, 10:31 PM
webroot/rsrc/css/application/conpherence/durable-column.css
64

Not that it's important, but floats imply block level.

btrahan mentioned this in T7380: Build icon-based room switcher for persistent chat pane.Mar 10 2015, 10:36 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
120 lines
src/
applications/
conpherence/
controller/
27 lines
view/
31 lines
webroot/
rsrc/
css/
application/
conpherence/
28 lines
js/
application/
conpherence/
9 lines

Diff 28974

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...
Phabricator · Built by Phacility