Differential D12030

Respect outbound HTTP setting in macro generation
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 9:03 PM.

Tags

None

Referenced Files

	F14107386: D12030.id.diff
	Wed, Nov 27, 7:59 AM

	F14107177: D12030.diff
	Wed, Nov 27, 7:28 AM

	F14102520: D12030.diff
	Tue, Nov 26, 7:09 PM

	Unknown Object (File)
	Thu, Nov 21, 4:44 PM

	Unknown Object (File)
	Sun, Nov 17, 5:59 PM

	Unknown Object (File)
	Thu, Nov 14, 3:30 AM

	Unknown Object (File)
	Sun, Nov 10, 7:15 AM

	Unknown Object (File)
	Wed, Nov 6, 6:01 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPf66edccf6220: Respect outbound HTTP setting in macro generation

Summary

We respect this when adding inputs to the form, but not when guarding the actual fetch.

Test Plan

Reading

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28954.Mar 9 2015, 9:03 PM

epriestley retitled this revision from to Respect outbound HTTP setting in macro generation.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 9:03 PM

btrahan accepted this revision.Mar 9 2015, 9:09 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 9 2015, 9:09 PM

Closed by commit rPf66edccf6220: Respect outbound HTTP setting in macro generation (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroEditController.php

2 lines

Diff 28955

View Options

src/applications/macro/controller/PhabricatorMacroEditController.php

Respect outbound HTTP setting in macro generationClosedPublicActions