Page MenuHomePhabricator
Differential D12027

Extend TransactionCommentQuery for Differential
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 7:46 PM
Unknown Object (File)
Tue, Apr 16, 6:23 PM
Unknown Object (File)
Thu, Apr 11, 7:02 AM
Unknown Object (File)
Fri, Apr 5, 11:17 PM
Unknown Object (File)
Fri, Apr 5, 9:56 PM
Unknown Object (File)
Mon, Apr 1, 11:07 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP7427a6e648cf: Extend TransactionCommentQuery for Differential
Summary

Ref T2009. Ref T1460. Replace hard-coded garbage with a real Query-layer query.

Test Plan

Submitted inline comments in Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28950.Mar 9 2015, 7:43 PM
epriestley retitled this revision from to Extend TransactionCommentQuery for Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T1460: Add "Done" link to an inline comment, T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 7:43 PM
btrahan accepted this revision.Mar 9 2015, 8:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 8:42 PM
Closed by commit rP7427a6e648cf: Extend TransactionCommentQuery for Differential (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 9:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
query/
31 lines
36 lines
transactions/
query/
30 lines
infrastructure/
diff/
query/
53 lines

Diff 28958

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/query/DifferentialDiffInlineCommentQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...
View Options

src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
Phabricator · Built by Phacility