Page MenuHomePhabricator

Reduce code duplication in inline right/left side tracking
ClosedPublic

Authored by epriestley on Mar 9 2015, 5:02 PM.
Tags
None
Referenced Files
F18827698: D12024.id28952.diff
Fri, Oct 24, 11:34 AM
F18817262: D12024.id28936.diff
Tue, Oct 21, 1:58 PM
F18784183: D12024.id.diff
Mon, Oct 13, 12:06 PM
F18784179: D12024.id28936.diff
Mon, Oct 13, 12:06 PM
F18784175: D12024.id28952.diff
Mon, Oct 13, 12:06 PM
F18773517: D12024.id28952.diff
Thu, Oct 9, 10:31 AM
F18771202: D12024.id.diff
Wed, Oct 8, 6:19 PM
F18767090: D12024.diff
Tue, Oct 7, 8:32 PM
Subscribers

Details

Summary

Ref T2009. These subclasses have a mixture of similar methods, move them all to the base class.

Test Plan

Created/edited/undo/submitted comments on the left and right sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reduce code duplication in inline right/left side tracking.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 6:55 PM
This revision was automatically updated to reflect the committed changes.