Page MenuHomePhabricator

Reduce code duplication in inline right/left side tracking
ClosedPublic

Authored by epriestley on Mar 9 2015, 5:02 PM.
Tags
None
Referenced Files
F18689741: D12024.id28952.diff
Fri, Sep 26, 6:27 PM
F18653827: D12024.id.diff
Sun, Sep 21, 8:02 PM
F18638018: D12024.diff
Wed, Sep 17, 8:57 AM
F18590521: D12024.id28936.diff
Fri, Sep 12, 6:18 AM
F18590341: D12024.id28936.diff
Fri, Sep 12, 5:50 AM
F18589982: D12024.id.diff
Fri, Sep 12, 4:49 AM
F18505127: D12024.id.diff
Sep 5 2025, 12:25 AM
F18497719: D12024.id.diff
Sep 4 2025, 6:12 PM
Subscribers

Details

Summary

Ref T2009. These subclasses have a mixture of similar methods, move them all to the base class.

Test Plan

Created/edited/undo/submitted comments on the left and right sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reduce code duplication in inline right/left side tracking.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 6:55 PM
This revision was automatically updated to reflect the committed changes.