Differential D12021

Hide revision content if author has not signed required legal documents
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 12:36 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T7446: When a revision requires a CLA, hide the text of the diff

Commits

Restricted Diffusion Commit
rPb7be4ccca187: Hide revision content if author has not signed required legal documents

Summary

Fixes T7446.

Test Plan

Screen_Shot_2015-03-08_at_5.33.12_PM.png (1×1 px, 214 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28931.Mar 9 2015, 12:36 AM

epriestley retitled this revision from to Hide revision content if author has not signed required legal documents.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7446: When a revision requires a CLA, hide the text of the diff.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 12:36 AM

btrahan accepted this revision.Mar 9 2015, 5:16 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/differential/controller/DifferentialRevisionViewController.php
452	looks like $comment_view gets appended twice in this code path

This revision is now accepted and ready to land.Mar 9 2015, 5:16 PM

btrahan awarded a token.Mar 9 2015, 5:17 PM

epriestley added inline comments.Mar 9 2015, 5:20 PM

src/applications/differential/controller/DifferentialRevisionViewController.php
452	Whoops, good catch. I've been scrolling past double comments all weekend.

One comment view is enough comment views.

Closed by commit rPb7be4ccca187: Hide revision content if author has not signed required legal documents (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

46 lines

docs/

user/

userguide/

legalpad.diviner

4 lines

Diff 28944

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php