Differential D12013

Use ChangesetListView in Phriction
ClosedPublic
Actions

Authored by epriestley on Mar 8 2015, 1:03 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity

Commits

Restricted Diffusion Commit
rP100760fb313e: Use ChangesetListView in Phriction

Summary

Ref T2009. Upgrade this from DetailView to ListView so we get "Highlight As", "View Unified", etc., and respect the unified diff prefernce.

Test Plan

Viewed diffs in Phriction.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28920.Mar 8 2015, 1:03 PM

epriestley retitled this revision from to Use ChangesetListView in Phriction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 8 2015, 1:03 PM

btrahan accepted this revision.Mar 9 2015, 5:15 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 9 2015, 5:15 PM

Closed by commit rP100760fb313e: Use ChangesetListView in Phriction (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDiffController.php

36 lines

Diff 28938

View Options

src/applications/phriction/controller/PhrictionDiffController.php

Use ChangesetListView in PhrictionClosedPublicActions