Page MenuHomePhabricator

Fix left/right detection of inline comments in unified view
ClosedPublic

Authored by epriestley on Mar 7 2015, 10:00 PM.
Tags
None
Referenced Files
F14013827: D12011.diff
Sat, Nov 2, 4:37 PM
F13990074: D12011.id28918.diff
Tue, Oct 22, 12:56 AM
F13988872: D12011.diff
Mon, Oct 21, 4:28 PM
Unknown Object (File)
Oct 11 2024, 6:47 AM
Unknown Object (File)
Oct 7 2024, 9:26 PM
Unknown Object (File)
Oct 1 2024, 2:10 PM
Unknown Object (File)
Sep 28 2024, 11:58 AM
Unknown Object (File)
Sep 24 2024, 10:47 AM
Subscribers

Details

Summary

Ref T2009. Currently, the code figures out if a comment is on the left or right by looking at the <th /> preceeding the enclosing <td />.

This gets the right result in 2-up, but in 1-up rows are always <th />, <th />, <td />, so it always detects every inline as being in the new file.

Because "old" and "new" cells aren't inherently distingushable in the 1up view, we can't use a DOM test for this at all. Instead, just track this state explicitly.

Test Plan
  • Made left/right comments in 1up view and 2up view.
  • Viewed them in 1up and 2up views.
  • Hovered in 1up and 2up views.
  • Diff-of-diff'd and reviewed old/new comments, then made some more.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix left/right detection of inline comments in unified view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2015, 10:30 PM
This revision was automatically updated to reflect the committed changes.