Differential D12010
Make inline comments more discoverable Authored by epriestley on Mar 7 2015, 7:37 PM. Tags None Referenced Files
Subscribers
Details
Ref T2009. Right now, when you mouse over a line number, we change the cursor to a "pointer", but that's the only hint we provide about the existence of inline comments. Occasionally, users have reported confusion around how to leave inline comments. Try to increase discoverability by showing the line reticle when you hover over the line. (I could take this or leave it, but it seems OK / not annoying after 15 seconds of playing with it.) Waved cursor over line numbers, attempted to test all the editor/noncontiguous/across-files cases.
Diff Detail
Event Timeline
Comment Actions It's kind of messy to do that in the drag state since we have to do a lot of fishing around to add/remove classes from all the <th />s. We don't currently need to identify or track the intermediate <th /> nodes.
Comment Actions The tricky case is when you're dragging across several nodes. Say you have this unified view:
If you click and drag from "1" in the right column to "2", in the right column, I'd expect these cells to get the hover effect:
Specifically, those are the rows where the yellow reticle will appear. We can use CSS to highlight the specific <th /> under the cursor, but that feels a little odd / inconsistent to me? Comment Actions Also, if you do that and then move your cursor over a <th /> in different file (while the mouse button is still held down), we'd highlight the cell but it's not actually targeted or active: logically, we're ignoring it, because it's not a valid drag target. Highlighting it visually feels weird/inconsistent there to me, too. I can make the <th /> highlighting match up with the reticle display relatively easily, it's just a big of extra code/mess. I'd rate it like a 3/10 on not wanting to do it because I'm lazy? If you're 4/10 on thinking it's cool/good or whatever, I'll add it. Comment Actions
Er, bit. It's going to be like 15 lines or something, it's just 15 lines of JS we could plausibly do without. Comment Actions I think it's likely the right thing, mostly you're mousing over/interacting with the numbers, but then we don't highlight them along with the code, so there is a slight disconnect. I played around with a few other similar apps and think it's likely the correct thing to do. Comment Actions If it makes you feel better, I'm about to go clean up cat vomit. Not that that's worse than writing javascript. Comment Actions
First impressions:
Anyway, play around with it and see how it feels. Comment Actions I also tried not highlighting the lines when you hovered a comment (vs hovering the line numbers). That felt OK for normal inlines, but a bit odd when hovering an "edit" inline. If the oddness sticks we could try adding hover state on edit inlines but not on submitted inlines. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
