Differential D12002

Conpherence - add ability to change title in the durable column
ClosedPublic
Actions

Authored by btrahan on Mar 6 2015, 5:29 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rP9b9a8001faae: Conpherence - add ability to change title in the durable column

Summary

Ref T7014.

Test Plan

changed the conpherence title from the column. since i can't get scrolling to work, i inspect the dom to verify the title change transaction showed up properly

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28891.Mar 6 2015, 5:29 PM

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

btrahan retitled this revision from to Conpherence - add ability to change title in the durable column.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptMar 6 2015, 5:29 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I feel like we should always have a title other than [No Title]. e.g., list of participants. I'll file a separate task.

epriestley accepted this revision.Mar 7 2015, 6:03 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/conpherence/view/ConpherenceDurableColumnView.php
207–216	Per me thinking this interaction is weird, what if we just put this in the dropdown menu, like "Rename Thread"? Then we could grey it out if you don't have permission, it would be obvious/discoverable/standard/etc. That leaves us with different interactions for "full" vs "column" Conpherence, but maybe we could find somewhere similar to put it in the full view. In particular, it might make sense to lift "Add Participants" up to the top level so you don't have to switch panels to do it? i..e, eventually have the same settings menu in "full" conpherence?

This revision is now accepted and ready to land.Mar 7 2015, 6:03 PM

chad added inline comments.Mar 7 2015, 7:03 PM

src/applications/conpherence/view/ConpherenceDurableColumnView.php
207–216	I'd +1 putting this in the menu. Mostly, I'd prefer clicking on the title explain Policy once we had public, project, personal Conpherences.

For consistency, maybe we could fit that in a subheader? Not sure exactly how things will break out, but something like:

Phacility
[lock] Private Room

Plot to Usurp Bob's Throne
[people] Private Thread

Funny Memes (LOL!)
[globe] Public Room

I don't know if we're really going to have a strong separation between "rooms" and "threads", but throwing it in the header makes a lot of sense to me if we do.

It's not information I think is needed to see all the time (it also might look pretty cluttered up there) In the mocks I just used the icon to hint the audience. If that information is needed, I'd probably look at having the audience re-iterated by the [Send] button.