Page MenuHomePhabricator
Differential D12001

Remove AphrontPanelView from Diffusion
ClosedPublic
Actions

Authored by chad on Mar 6 2015, 4:45 PM.
Tags
None
Referenced Files
F14850374: D12001.id28899.diff
Tue, Feb 4, 5:37 AM
Unknown Object (File)
Fri, Jan 31, 12:01 AM
Unknown Object (File)
Tue, Jan 28, 8:56 PM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7427: Remove remaining AphrontPanelViews
Commits
Restricted Diffusion Commit
rP6909e6206e44: Remove AphrontPanelView from Diffusion
Summary

Removes remaining AphrontPanelView calls in Diffusion for UI Consistency.

Test Plan

Tested each page except lint details, which I couldn't quite find a path to. Everything looks right.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28889.Mar 6 2015, 4:45 PM
chad retitled this revision from to Remove AphrontPanelView from Diffusion.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 6 2015, 4:45 PM
chad added a task: T7427: Remove remaining AphrontPanelViews.Mar 6 2015, 4:46 PM
chad updated this revision to Diff 28890.Mar 6 2015, 4:48 PM
  • move pager outside of ObjectBox
btrahan accepted this revision.Mar 6 2015, 11:01 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 11:01 PM
Closed by commit rP6909e6206e44: Remove AphrontPanelView from Diffusion (authored by chad, committed by chad). · Explain WhyMar 6 2015, 11:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28899

View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionExternalController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintDetailsController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionSymbolController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionTagListController.php

Loading...
Phabricator · Built by Phacility