Page MenuHomePhabricator
Differential D11998

Remove duplicate inline row scaffold in 1up renderer
ClosedPublic
Actions

Authored by epriestley on Mar 6 2015, 1:53 PM.
Tags
None
Referenced Files
F18874089: D11998.id.diff
Wed, Nov 5, 1:00 PM
F18868046: D11998.diff
Tue, Nov 4, 4:19 AM
F18834619: D11998.id28895.diff
Sun, Oct 26, 9:54 AM
F18784272: D11998.id28895.diff
Oct 13 2025, 12:15 PM
F18784269: D11998.id.diff
Oct 13 2025, 12:15 PM
F18784268: D11998.id28886.diff
Oct 13 2025, 12:15 PM
F18784148: D11998.diff
Oct 13 2025, 12:01 PM
F18777603: D11998.id28886.diff
Oct 11 2025, 3:51 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rPac60b23ef9e2: Remove duplicate inline row scaffold in 1up renderer
Summary

Ref T2009. This can now be removed.

Test Plan

Added, edited and deleted an inline comment in 1up view.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28886.Mar 6 2015, 1:53 PM
epriestley retitled this revision from to Remove duplicate inline row scaffold in 1up renderer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 6 2015, 1:53 PM
btrahan accepted this revision.Mar 6 2015, 10:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:58 PM
Closed by commit rPac60b23ef9e2: Remove duplicate inline row scaffold in 1up renderer (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2015, 11:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 28895

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
Phabricator · Built by Phacility