Page MenuHomePhabricator

Begin separating inline comment scaffolding from other renderers
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 19 2024, 7:26 AM
Unknown Object (File)
Oct 16 2024, 1:37 PM
Unknown Object (File)
Oct 8 2024, 12:06 AM
Unknown Object (File)
Oct 1 2024, 4:41 AM
Unknown Object (File)
Sep 16 2024, 1:24 PM
Unknown Object (File)
Sep 8 2024, 5:00 PM
Unknown Object (File)
Sep 6 2024, 7:46 AM
Unknown Object (File)
Sep 5 2024, 4:56 PM
Subscribers

Details

Summary

Ref T2009. Inline comments have "scaffolding", which is basically some empty table cells/rows around them to get the layout correct.

The scaffolding depends on the renderer, since the cells are different for side-by-side vs unified diffs.

This is currently duplicated all over the place:

  • Edit view has 1up/2up.
  • Detail view has 1up/2up.
  • 1up renderer has 1up.
  • 2up renderer has four separate copies of the 2up logic.

These all have subtle differences, which are mostly bugs. Start making the scaffolding more composable so we can get rid of that mess.

Test Plan

Added, edited, and removed inline comments on unified and side-by-side diffs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin separating inline comment scaffolding from other renderers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:58 PM
This revision was automatically updated to reflect the committed changes.