Page MenuHomePhabricator

Unify changeset line ID rendering and bring it to unified diffs
ClosedPublic

Authored by epriestley on Mar 5 2015, 5:02 PM.
Tags
None
Referenced Files
F13087488: D11983.diff
Thu, Apr 25, 12:59 AM
Unknown Object (File)
Tue, Apr 9, 4:53 AM
Unknown Object (File)
Wed, Apr 3, 8:46 PM
Unknown Object (File)
Tue, Apr 2, 12:11 AM
Unknown Object (File)
Fri, Mar 29, 6:38 PM
Unknown Object (File)
Fri, Mar 29, 4:14 PM
Unknown Object (File)
Fri, Mar 29, 1:31 AM
Unknown Object (File)
Thu, Mar 28, 3:47 PM
Subscribers

Details

Summary

Ref T2009. Currently, lines don't get their "C123NL456" IDs set in the unified view. This is the major way that inlines are glued to changesets.

Simplify this rendering and bring it into the HTML renderer, then use it in the OneUp renderer.

Test Plan
  • Interacted with side-by-side inlines (hovered, added, edited, deleted), saw unchanged behavior.
  • Interacted with unified inlines. They still don't work, but the error that breaks them is deeper in the stack.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Unify changeset line ID rendering and bring it to unified diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 9:02 PM
This revision was automatically updated to reflect the committed changes.