Ref T2009. Currently, lines don't get their "C123NL456" IDs set in the unified view. This is the major way that inlines are glued to changesets.
Simplify this rendering and bring it into the HTML renderer, then use it in the OneUp renderer.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
- Commits
- Restricted Diffusion Commit
rP35c1dbf1f8a4: Unify changeset line ID rendering and bring it to unified diffs
- Interacted with side-by-side inlines (hovered, added, edited, deleted), saw unchanged behavior.
- Interacted with unified inlines. They still don't work, but the error that breaks them is deeper in the stack.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable