Differential D11975

Move "webkit-text-blah" to "<body>" to make it work
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 2:01 AM.

Tags

None

Referenced Files

	F18804445: D11975.id.diff
	Sat, Oct 18, 8:22 AM

	F18796229: D11975.id28826.diff
	Fri, Oct 17, 3:08 AM

	F18784289: D11975.id28826.diff
	Mon, Oct 13, 12:17 PM

	F18784279: D11975.id28861.diff
	Mon, Oct 13, 12:16 PM

	F18784278: D11975.id.diff
	Mon, Oct 13, 12:16 PM

	F18784150: D11975.diff
	Mon, Oct 13, 12:02 PM

	F18763456: D11975.diff
	Tue, Oct 7, 12:17 AM

	F18750139: D11975.diff
	Sat, Oct 4, 6:41 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity

Commits

Restricted Diffusion Commit
rP175a989e2865: Move "webkit-text-blah" to "<body>" to make it work

Summary

Ref T2009. This doesn't work when it's not on <body>, at least in modern iOS.

Test Plan

Before:

Screen_Shot_2015-03-04_at_5.58.20_PM.png (884×1 px, 147 KB)

After:

Screen_Shot_2015-03-04_at_5.59.12_PM.png (884×1 px, 135 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28826.Mar 5 2015, 2:01 AM

epriestley retitled this revision from to Move "webkit-text-blah" to "<body>" to make it work.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 2:01 AM

Getting almost usable in trivial cases:

Screen_Shot_2015-03-04_at_6.03.29_PM.png (884×1 px, 187 KB)

chad accepted this revision.Mar 5 2015, 2:16 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2015, 2:16 AM

Closed by commit rP175a989e2865: Move "webkit-text-blah" to "<body>" to make it work (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

core.css

14 lines

Diff 28861

View Options

resources/celerity/map.php