Page MenuHomePhabricator
Differential D11974

Provide "diff-1up" and "diff-2up" classes and tweak some styles
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 1:57 AM.
Tags
None
Referenced Files
F18784215: D11974.id.diff
Mon, Oct 13, 12:07 PM
F18784208: D11974.id28860.diff
Mon, Oct 13, 12:07 PM
F18784206: D11974.id28825.diff
Mon, Oct 13, 12:06 PM
F18784121: D11974.diff
Mon, Oct 13, 11:54 AM
F18782115: D11974.id28825.diff
Mon, Oct 13, 12:37 AM
F18770910: D11974.id.diff
Wed, Oct 8, 4:07 PM
F18758915: D11974.diff
Mon, Oct 6, 12:28 AM
F18739935: D11974.id28825.diff
Wed, Oct 1, 11:36 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rP79cb47116ed1: Provide "diff-1up" and "diff-2up" classes and tweak some styles
Summary

Ref T2009. Remove forced min-width of 780px in 1-up mode, and tweak a few other things to look better.

Test Plan

Looks better on mobile.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28825.Mar 5 2015, 1:57 AM
epriestley retitled this revision from to Provide "diff-1up" and "diff-2up" classes and tweak some styles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a reviewer: chad. · View Herald TranscriptMar 5 2015, 1:57 AM
Herald added a subscriber: epriestley. · View Herald Transcript
chad accepted this revision.Mar 5 2015, 2:15 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 2:15 AM
Closed by commit rP79cb47116ed1: Provide "diff-1up" and "diff-2up" classes and tweak some styles (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
differential/
render/
10 lines
4 lines
4 lines
webroot/
rsrc/
css/
application/
differential/
26 lines

Diff 28860

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility