Differential D11955

Forbid adding non-users to Conpherence threads
ClosedPublic
Actions

Authored by epriestley on Mar 3 2015, 12:42 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6724: Conduit allows non-users to be added to Conpherences

Commits

Restricted Diffusion Commit
rP47b54389e5a3: Forbid adding non-users to Conpherence threads

Summary

Fixes T6724. Adds validation that participants are users.

Test Plan

Tried to add non-users, got an error.
Added users normally.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28781.Mar 3 2015, 12:42 PM

epriestley retitled this revision from to Forbid adding non-users to Conpherence threads.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6724: Conduit allows non-users to be added to Conpherences.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 3 2015, 12:42 PM

btrahan accepted this revision.Mar 3 2015, 3:25 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2015, 3:25 PM

Closed by commit rP47b54389e5a3: Forbid adding non-users to Conpherence threads (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2015, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

editor/

ConpherenceEditor.php

39 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

9 lines

Diff 28793

View Options

src/applications/conpherence/editor/ConpherenceEditor.php