Page MenuHomePhabricator
Differential D11897

Add a noDataString function to FeedBuilder
ClosedPublic
Actions

Authored by chad on Feb 26 2015, 7:34 PM.
Tags
None
Referenced Files
F15369287: D11897.diff
Wed, Mar 12, 6:02 AM
F15333863: D11897.id28660.diff
Sat, Mar 8, 5:13 AM
Unknown Object (File)
Wed, Feb 26, 10:57 PM
Unknown Object (File)
Mon, Feb 24, 2:47 PM
Unknown Object (File)
Thu, Feb 13, 1:16 PM
Unknown Object (File)
Feb 8 2025, 2:45 AM
Unknown Object (File)
Feb 8 2025, 2:45 AM
Unknown Object (File)
Feb 8 2025, 2:45 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7383: Empty Feed is sad Feed
Commits
Restricted Diffusion Commit
rP36b049c7cc70: Add a noDataString function to FeedBuilder
Summary

Feed currently returns nothing is there are no stories, we can present a better view here by allowing a base and customizable set of errors. Fixes T7383

Test Plan

Test a Project feed with no noDataSting and People with a noDataSting

Screen_Shot_2015-02-26_at_11.31.08_AM.png (664×1 px, 59 KB)

Screen_Shot_2015-02-26_at_11.30.38_AM.png (574×1 px, 65 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28660.Feb 26 2015, 7:34 PM
chad retitled this revision from to Add a noDataString function to FeedBuilder.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T7383: Empty Feed is sad Feed.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 26 2015, 7:34 PM
chad edited the test plan for this revision. (Show Details)Feb 26 2015, 7:34 PM
epriestley accepted this revision.Feb 27 2015, 7:39 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2015, 7:39 PM
Closed by commit rP36b049c7cc70: Add a noDataString function to FeedBuilder (authored by chad, committed by chad). · Explain WhyFeb 27 2015, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
feed/
builder/
20 lines
people/
controller/
2 lines
webroot/
rsrc/
css/
application/
profile/
4 lines

Diff 28677

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/feed/builder/PhabricatorFeedBuilder.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleFeedController.php

Loading...
View Options

webroot/rsrc/css/application/profile/profile-view.css

Loading...
Phabricator · Built by Phacility