Page MenuHomePhabricator

Fix Maniphest Reports scrolling issues
ClosedPublic

Authored by chad on Feb 24 2015, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 12:23 AM
Unknown Object (File)
Feb 12 2024, 2:17 AM
Unknown Object (File)
Feb 7 2024, 6:34 PM
Unknown Object (File)
Feb 7 2024, 5:10 PM
Unknown Object (File)
Jan 1 2024, 11:12 AM
Unknown Object (File)
Dec 13 2023, 1:22 AM
Unknown Object (File)
Dec 2 2023, 2:09 PM
Unknown Object (File)
Nov 30 2023, 6:00 AM
Subscribers

Details

Summary

Fixes T7099, also picked some new colors. Raphael can bind the graph to a dom element, which resolved the scrolling issue.

Test Plan

Tested scrolling on my laptop, desktop. Seems resolved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Fix Maniphest reports.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad retitled this revision from Fix Maniphest reports to Fix Maniphest Reports scrolling issues.Feb 24 2015, 5:34 PM
btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/css/application/maniphest/report.css
15–16

looks like we lost some CSS rules; just double checking that was intended

webroot/rsrc/js/application/maniphest/behavior-line-chart.js
16

this is a wacky constructor IMO - weird to see two parameters can instead be a single parameter of a different type - but hey we didn't write it!

This revision is now accepted and ready to land.Feb 24 2015, 5:36 PM
webroot/rsrc/css/application/maniphest/report.css
15–16

These are pretty well denoted by "Week of" that they don't also need a color.

webroot/rsrc/js/application/maniphest/behavior-line-chart.js
16
This revision was automatically updated to reflect the committed changes.