Fix scrolling over nav area
AbandonedPublic
Actions

Authored by chad on Feb 24 2015, 4:58 AM.

Tags

None

Referenced Files

	F14020388: D11876.diff
	Wed, Nov 6, 12:28 AM

	F14019105: D11876.id28599.diff
	Tue, Nov 5, 9:33 PM

	F14019104: D11876.id28598.diff
	Tue, Nov 5, 9:33 PM

	F14019102: D11876.id.diff
	Tue, Nov 5, 9:33 PM

	F14016478: D11876.diff
	Mon, Nov 4, 9:53 AM

	F14007925: D11876.diff
	Tue, Oct 29, 1:01 PM

	F14007819: D11876.diff
	Tue, Oct 29, 11:55 AM

	F13993245: D11876.id28599.diff
	Tue, Oct 22, 9:40 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Summary

I *think* this fixes the main issues, mostly by making the nav 100% tall (though invisible). Fixes T7052

Test Plan

Need to bang on this some more, but seems promising. Tested home with lots and little of items, maniphest, others.

Diff Detail

Repository

rP Phabricator

Branch

sidebar-scrolley-polley

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4636
Build 4650: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28598.Feb 24 2015, 4:58 AM

chad retitled this revision from to Fix scrolling over nav area.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T7052: Unable to scroll after clicking in left sidebar.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 24 2015, 4:58 AM

Restrict to desktop only

I'm going to defer to Evan on this whacky scrollbar stuff. Otherwise though LGTM!

Doesn't play well with IconNav, but should be fixable. Only issue I've been able to spot, but will keep poking.

chad abandoned this revision.Feb 25 2015, 12:13 AM

chad removed a task: T7052: Unable to scroll after clicking in left sidebar.Feb 25 2015, 12:54 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

aphront/

phabricator-nav-view.css

8 lines

Diff 28599

View Options

resources/celerity/map.php