Page MenuHomePhabricator

Fix scrolling over nav area
AbandonedPublic

Authored by chad on Feb 24 2015, 4:58 AM.
Tags
None
Referenced Files
F18347452: D11876.diff
Tue, Aug 26, 3:10 PM
F18302620: D11876.diff
Sat, Aug 23, 8:59 PM
F18226822: D11876.id.diff
Wed, Aug 20, 4:53 AM
F18218440: D11876.diff
Tue, Aug 19, 10:12 AM
F18089683: D11876.diff
Wed, Aug 6, 12:00 PM
F18048435: D11876.id.diff
Sun, Aug 3, 1:34 PM
Unknown Object (File)
Jun 19 2025, 5:00 AM
Unknown Object (File)
Jun 18 2025, 6:03 PM
Subscribers

Details

Summary

I *think* this fixes the main issues, mostly by making the nav 100% tall (though invisible). Fixes T7052

Test Plan

Need to bang on this some more, but seems promising. Tested home with lots and little of items, maniphest, others.

Diff Detail

Repository
rP Phabricator
Branch
sidebar-scrolley-polley
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4636
Build 4650: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Fix scrolling over nav area.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
  • Restrict to desktop only

I'm going to defer to Evan on this whacky scrollbar stuff. Otherwise though LGTM!

chad planned changes to this revision.Feb 24 2015, 5:58 PM

Doesn't play well with IconNav, but should be fixable. Only issue I've been able to spot, but will keep poking.