Page MenuHomePhabricator

Implement memory reserves in autoscale pools
ClosedPublic

Authored by epriestley on Feb 23 2015, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 10:16 AM
Unknown Object (File)
Tue, Apr 16, 10:15 AM
Unknown Object (File)
Thu, Apr 11, 8:04 AM
Unknown Object (File)
Fri, Apr 5, 6:22 AM
Unknown Object (File)
Mon, Apr 1, 6:37 PM
Unknown Object (File)
Mar 19 2024, 6:33 PM
Unknown Object (File)
Feb 23 2024, 11:39 PM
Unknown Object (File)
Feb 7 2024, 2:18 PM
Subscribers

Details

Summary

Ref T7352. If an autoscale pool specifies a memory reserve, don't scale the pool up unless the machine has at least that proportion of its RAM free.

This is off by default because it doesn't impact most users and we may not be able to get memory information on some systems (e.g., FreeBSD).

Test Plan

Changed "HighIntensity" daemon to:

  • Always remain busy.
  • Use 512MB of RAM for no reason.

Changed phd debug --autoscale to:

  • Specify a reserve of 0.15.
  • Specify a pool size of 1024.

Then, observed:

  • Pool expanded up to 6 daemons, bringing reserve down from 30% of system RAM to 13%.
  • Pool stopped expanding at this point and remained at a fixed size.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement memory reserves in autoscale pools.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2015, 6:37 PM
epriestley edited edge metadata.

(Proper test plan.)

This revision was automatically updated to reflect the committed changes.