Phriction - clarify error message when trying to delete already deleted content
ClosedPublic
Actions

Authored by btrahan on Feb 19 2015, 11:22 PM.

Details

Reviewers

Maniphest Tasks

T7328: Editing the title of a deleted wiki page results in: An already deleted document can not be deleted.
T7325: Changing permissions of a moved wiki page results in: A moved document can not be deleted.
T7326: Title not moved along with rest of wiki page

Commits

Restricted Diffusion Commit
rP0a0ac1142953: Phriction - clarify error message when trying to delete already deleted content

Summary

Fixes T7325, T7326, T7328. When you have deleted a document already you have to specify content; this makes this more clear to the user in this specific delete pathway. Also, includes bonus bug fix for T7326 where we weren't moving the title of the wiki page with the rest of the page.

Test Plan

moved a wiki doc and verified it had the title I had specified. tried to delete an already deleted doc via setting the content to blank (i.e. hitting save after making some other edits) and got more clear error UI state

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28515.Feb 19 2015, 11:22 PM

btrahan retitled this revision from to Phriction - clarify error message when trying to delete already deleted content.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added tasks: T7326: Title not moved along with rest of wiki page, T7325: Changing permissions of a moved wiki page results in: A moved document can not be deleted., T7328: Editing the title of a deleted wiki page results in: An already deleted document can not be deleted..

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 19 2015, 11:22 PM

Perhaps a better fix overall would be to allow people to change the title and policy of deleted wiki pages.

At least title is complicated because "changing the title" is really "adding a new content object with a new title" and that always upgrades a given doc from deleted to existence. This codepath could of course be massaged to allow for this sort of thing, just with a more complication than this diff has.