Differential D11821

Improve visibility of repository credential errors
ClosedPublic
Actions

Authored by epriestley on Feb 19 2015, 3:08 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7310: Improve UX around bad repository credentials

Commits

Restricted Diffusion Commit
rP35c55f7ddfd3: Improve visibility of repository credential errors

Summary

Fixes T7310. We have a whole mechanism for surfacing update errors, but only surface actual update errors, not pull errors.

Instead, surface pull errors too.

Then format them a little more nicely.

Test Plan

Screen_Shot_2015-02-19_at_7.06.00_AM.png (1×1 px, 287 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28492.Feb 19 2015, 3:08 PM

epriestley retitled this revision from to Improve visibility of repository credential errors.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7310: Improve UX around bad repository credentials.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 19 2015, 3:08 PM

btrahan accepted this revision.Feb 19 2015, 6:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 19 2015, 6:24 PM

btrahan awarded a token.Feb 19 2015, 6:24 PM

For consistency, unlock lock when returning early.

Closed by commit rP35c55f7ddfd3: Improve visibility of repository credential errors (authored by epriestley, committed by epriestley). · Explain WhyFeb 19 2015, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryEditMainController.php

25 lines

repository/

management/

PhabricatorRepositoryManagementUpdateWorkflow.php

31 lines

Diff 28504

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php