Page MenuHomePhabricator

Touch up Audit/Commit List UI
ClosedPublic

Authored by chad on Feb 19 2015, 12:25 AM.
Tags
None
Referenced Files
F18844969: D11817.diff
Wed, Oct 29, 8:42 AM
F18835750: D11817.id.diff
Sun, Oct 26, 6:32 PM
F18825657: D11817.id28490.diff
Thu, Oct 23, 11:20 PM
F18790634: D11817.id28484.diff
Wed, Oct 15, 4:10 PM
F18782905: D11817.id28485.diff
Mon, Oct 13, 2:56 AM
F18735822: D11817.id.diff
Oct 1 2025, 3:29 AM
F18712437: D11817.id.diff
Sep 29 2025, 5:24 AM
F18711923: D11817.diff
Sep 29 2025, 5:09 AM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPe2fcc3c1879c: Touch up Audit/Commit List UI
Summary

Fixes a few issues. The author of the commit is more prominent / not cut off. Auditors is in a more consistent location. More space is available for reasons. Commits by themselves look much less janky. Only downside is actual Audits are now 3 lines vs. 2, but the extra space is used well.

Test Plan

Test list of audits and commits.

pasted_file (378×1 px, 127 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Touch up Audit/Commit List UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2015, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Is there any point in showing commit author name, used in VCS system (name & e-mail in git) VS resolved Phabricator username with a link? Then we could have kept 2 line element.

Here is how it looks (picture from my fork):

Phabricator_AuditList_AuthorLink.png (125×800 px, 27 KB)

I don't know the history of the code well enough to give you an answer. I would like to split "Commits" vs. "Commits with Audits" UI out further, but I don't know when we'd approach that. T6630 would likely be the place to pursue more improvements there.