Only increment status message cursor if we're going to consume the message
ClosedPublic
Actions

Authored by epriestley on Feb 18 2015, 8:47 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPdd969673060f: Only increment status message cursor if we're going to consume the message

Summary

Fixes the long uptake we saw on meta.phacility.com. I regressed this in D11795.

We make three calls to this method, but only one actually consumes the messages. The other two are just checking to see if there are any messages.

Only move the cursor up if we're actually going to process the messages.

Test Plan

Sort of tricky to test convincingly since it's inherently race-prone, but ran debug pulllocal and pushed update messages and saw it pick them up.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28465.Feb 18 2015, 8:47 PM

epriestley retitled this revision from to Only increment status message cursor if we're going to consume the message.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 18 2015, 8:47 PM

btrahan accepted this revision.Feb 18 2015, 8:52 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2015, 8:52 PM

Closed by commit rPdd969673060f: Only increment status message cursor if we're going to consume the message (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2015, 8:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

daemon/

PhabricatorRepositoryPullLocalDaemon.php

23 lines

Diff 28466

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Only increment status message cursor if we're going to consume the messageClosedPublicActions