Differential D11794

Project - don't create the empty tag on create anymore
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 11:01 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7284: Creating a project gives it the empty hashtag

Commits

Restricted Diffusion Commit
rP52f724e6cf49: Project - don't create the empty tag on create anymore

Summary

Fixes T7284. We were initialized the project name to the empty string, which was making things work like a rename, including automagically adding the old slug.

Test Plan

made a project and no more "empty" tag being made. also don't have that bad transaction story anymore.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28431.Feb 17 2015, 11:01 PM

btrahan added a task: T7284: Creating a project gives it the empty hashtag.

btrahan retitled this revision from to Project - don't create the empty tag on create anymore.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 11:01 PM

epriestley accepted this revision.Feb 17 2015, 11:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2015, 11:01 PM

Closed by commit rP52f724e6cf49: Project - don't create the empty tag on create anymore (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 11:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

storage/

PhabricatorProject.php

1 line

Diff 28432

View Options

src/applications/project/storage/PhabricatorProject.php

Project - don't create the empty tag on create anymoreClosedPublicActions