Differential D11785

Legalpad - fix requires signature transaction from always being saved
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 7:05 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7295: Saving a Legalpad document without making changes generates a "not require signatures" transaction

Commits

Restricted Diffusion Commit
rP82f47f968989: Legalpad - fix requires signature transaction from always being saved

Summary

Fixes T7295. Humbling debugging experience but I got it.

Test Plan

saved a legalpad doc without edits over and over and saw no "requires signature" transaction. toggled "requires signature", saved, and saw the transaction.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28406.Feb 17 2015, 7:05 PM

btrahan added a task: T7295: Saving a Legalpad document without making changes generates a "not require signatures" transaction.

btrahan retitled this revision from to Legalpad - fix requires signature transaction from always being saved.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 7:05 PM

epriestley accepted this revision.Feb 17 2015, 7:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2015, 7:06 PM

Closed by commit rP82f47f968989: Legalpad - fix requires signature transaction from always being saved (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 7:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

editor/

LegalpadDocumentEditor.php

7 lines

Diff 28408

View Options

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Legalpad - fix requires signature transaction from always being savedClosedPublicActions