Differential D11732

Subversion - set minimum required version to 1.5
ClosedPublic
Actions

Authored by btrahan on Feb 10 2015, 7:05 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7228: Probably blacklist SVN 1.4 as too old?

Commits

Restricted Diffusion Commit
rP91a1f56a4c25: Subversion - set minimum required version to 1.5

Summary

Fixes T7228.

Test Plan

hacked $version to be '1.4' and saw the proper error message

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28262.Feb 10 2015, 7:05 PM

btrahan added a task: T7228: Probably blacklist SVN 1.4 as too old?.

btrahan retitled this revision from to Subversion - set minimum required version to 1.5.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 10 2015, 7:05 PM

epriestley accepted this revision.Feb 10 2015, 7:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2015, 7:29 PM

epriestley added inline comments.Feb 10 2015, 7:29 PM

src/applications/config/check/PhabricatorBinariesSetupCheck.php
109	Oh, this is misspelled ("Subverison" vs "Subversion")>

Closed by commit rP91a1f56a4c25: Subversion - set minimum required version to 1.5 (authored by btrahan, committed by btrahan). · Explain WhyFeb 10 2015, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorBinariesSetupCheck.php

5 lines

Diff 28269

View Options

src/applications/config/check/PhabricatorBinariesSetupCheck.php

Subversion - set minimum required version to 1.5ClosedPublicActions