Clean up authentication list
ClosedPublic
Actions

Authored by chad on Feb 7 2015, 5:42 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP272ce408dcd3: Clean up authentication list

Summary

Uses more standard boxes for display, and icons!

Test Plan

Test with all enabled, all disabled, and a mix.

Screen_Shot_2015-02-07_at_9.41.12_AM.png (678×2 px, 155 KB)

Screen_Shot_2015-02-07_at_9.39.40_AM.png (998×2 px, 202 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28175.Feb 7 2015, 5:42 PM

chad retitled this revision from to Clean up authentication list.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 7 2015, 5:42 PM

chad edited the test plan for this revision. (Show Details)Feb 7 2015, 5:43 PM

Move warning outside of box

Decided maybe warning should be outside since it's important.

I think putting the warning inside is OK. This warning was added before we added administrative account approvals, which are enabled by default, so it is much less important than it once was. I should really touch up the warning to include a check for approvals. I can kick you a followup.

This revision is now accepted and ready to land.Feb 7 2015, 6:36 PM

Closed by commit rP272ce408dcd3: Clean up authentication list (authored by chad, committed by chad). · Explain WhyFeb 7 2015, 6:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7208: Improve auth issues warning in Phacility cluster?.Feb 7 2015, 6:55 PM