Page MenuHomePhabricator

Clean up authentication list
ClosedPublic

Authored by chad on Feb 7 2015, 5:42 PM.
Tags
None
Referenced Files
F14040168: D11707.diff
Mon, Nov 11, 7:39 AM
F14022486: D11707.diff
Wed, Nov 6, 5:54 PM
F14007777: D11707.diff
Tue, Oct 29, 11:33 AM
F14000113: D11707.diff
Thu, Oct 24, 7:20 PM
F13985455: D11707.diff
Sun, Oct 20, 8:37 PM
F13979444: D11707.id28176.diff
Sat, Oct 19, 4:35 AM
F13959247: D11707.id28177.diff
Mon, Oct 14, 6:28 PM
Unknown Object (File)
Oct 11 2024, 2:30 PM
Subscribers

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP272ce408dcd3: Clean up authentication list
Summary

Uses more standard boxes for display, and icons!

Test Plan

Test with all enabled, all disabled, and a mix.

Screen_Shot_2015-02-07_at_9.41.12_AM.png (678×2 px, 155 KB)

Screen_Shot_2015-02-07_at_9.39.40_AM.png (998×2 px, 202 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Clean up authentication list.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
  • Move warning outside of box

Decided maybe warning should be outside since it's important.

pasted_file (497×1 px, 117 KB)

epriestley edited edge metadata.

I think putting the warning inside is OK. This warning was added before we added administrative account approvals, which are enabled by default, so it is much less important than it once was. I should really touch up the warning to include a check for approvals. I can kick you a followup.

This revision is now accepted and ready to land.Feb 7 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.