Page MenuHomePhabricator
Differential D11702

People - refine permissions on creating new users
ClosedPublic
Actions

Authored by btrahan on Feb 6 2015, 12:45 AM.
Tags
None
Referenced Files
F15413463: D11702.id28159.diff
Wed, Mar 19, 6:55 PM
F15403155: D11702.id28158.diff
Tue, Mar 18, 2:02 AM
F15400615: D11702.id.diff
Mon, Mar 17, 12:52 PM
F15397133: D11702.diff
Sun, Mar 16, 6:22 PM
F15392168: D11702.id.diff
Sat, Mar 15, 1:36 PM
F15389286: D11702.id28158.diff
Sat, Mar 15, 5:05 AM
F15378772: D11702.id28158.diff
Thu, Mar 13, 4:56 PM
F15357602: D11702.id28159.diff
Tue, Mar 11, 6:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7142: Allow instances to create bot accounts
Commits
Restricted Diffusion Commit
rP345966cb4131: People - refine permissions on creating new users
Summary

Fixes T7142. Make old permission mean "make (non-bot) users" and then nuance the UI for those administrators who can make bot accounts.

Test Plan

loaded up admin a with full powers and admin b with restricted powers. noted admin a could make a full user. noted admin b could not make a full user. noted admin b got an error even via clever uri hacking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28158.Feb 6 2015, 12:45 AM
btrahan added a task: T7142: Allow instances to create bot accounts.
btrahan retitled this revision from to People - refine permissions on creating new users.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 6 2015, 12:45 AM
epriestley accepted this revision.Feb 6 2015, 12:46 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2015, 12:46 AM
Closed by commit rP345966cb4131: People - refine permissions on creating new users (authored by btrahan, committed by btrahan). · Explain WhyFeb 6 2015, 12:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
application/
13 lines
capability/
2 lines
controller/
19 lines
4 lines

Diff 28159

View Options

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...
View Options

src/applications/people/capability/PeopleCreateUsersCapability.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleListController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Loading...
Phabricator · Built by Phacility