Page MenuHomePhabricator

Only let users log in to an OAuth server if they can see it
ClosedPublic

Authored by epriestley on Feb 5 2015, 6:55 PM.

Details

Summary

Fixes T7169. We just weren't doing a policy-aware query. Basic idea here is that if you set an app to be visible only to specific users, those specific users are the only ones who should be able to authorize it.

In the Phacility cluster, this allows us to prevent users who haven't been invited from logging in to an instance.

Test Plan
  • Tried to log into an instance I was not a member of.
  • Logged into an instance I am a member of.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Only let users log in to an OAuth server if they can see it.Feb 5 2015, 6:55 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 28142.
btrahan edited edge metadata.Feb 5 2015, 6:57 PM
btrahan accepted this revision.
This revision is now accepted and ready to land.Feb 5 2015, 6:57 PM
This revision was automatically updated to reflect the committed changes.