Fixes T7118. This does the basic "filter the list" thing, though it ends up being a little manual since I guess this hasn't come up before? There is also potential weird behavior if the user was using an app and lost access to it - they will have nothing selected on edit - but I think this is actually correct behavior in this circumstance.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7118: Dashboard show queries for uninstalled/prototype applications
- Commits
- Restricted Diffusion Commit
rP5a9df1a22526: Policy - filter app engines where the user can't see the application from…
used a user who couldn't get access to the "quick create" apps and noted that the dropdown list on dashboard panel create was missing the expected engines
ran arc unit --everything to verify abstract method implemented everywhere
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/search/engine/PhabricatorApplicationSearchEngine.php | ||
|---|---|---|
| 245–246 | Can we just make this abstract now? The dashboard will fatal if anything doesn't implement it since it tries to call it on every engine, so it would be better to catch it in the TestEverythingImplemented test than at runtime. | |