Page MenuHomePhabricator
Differential D11665

Arcanist / Conduit - stop using deprecated differential.getdiff API
ClosedPublic
Actions

Authored by btrahan on Feb 3 2015, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 7:07 AM
Unknown Object (File)
Mon, Jan 27, 11:20 PM
Unknown Object (File)
Mon, Jan 27, 10:40 AM
Unknown Object (File)
Thu, Jan 23, 11:35 PM
Unknown Object (File)
Thu, Jan 23, 11:35 PM
Unknown Object (File)
Thu, Jan 23, 11:35 PM
Unknown Object (File)
Thu, Jan 23, 11:35 PM
Unknown Object (File)
Wed, Jan 22, 8:37 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7112: Remove deprecated "differential.getdiff" calls from arcanist
Commits
rARCd98c1049910d: Arcanist / Conduit - stop using deprecated differential.getdiff API
Summary

Fixes T7112. Nothing too difficult here.

Test Plan

meta - submitting this with the new arcanist code
used conduit API to verify the difference between getdiff (just the latest diff) and querydiffs (all diffs that match, with the latest diff first in the set)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28075.Feb 3 2015, 10:02 PM
btrahan added a task: T7112: Remove deprecated "differential.getdiff" calls from arcanist.
btrahan retitled this revision from to Arcanist / Conduit - stop using deprecated differential.getdiff API.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 10:02 PM
btrahan edited the test plan for this revision. (Show Details)Feb 3 2015, 10:04 PM
epriestley accepted this revision.Feb 3 2015, 10:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 10:06 PM
Closed by commit rARCd98c1049910d: Arcanist / Conduit - stop using deprecated differential.getdiff API (authored by btrahan, committed by btrahan). · Explain WhyFeb 3 2015, 10:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28077

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistFeatureWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility